Closed
Bug 634995
Opened 14 years ago
Closed 14 years ago
unify redundant methods runTestModule and _runTestModule
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
Details
(Whiteboard: [mozmill-2.0+])
Attachments
(1 file)
|
845 bytes,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
we have a runTestModule function that only calls _runTestModule. As
best I can tell there is absolutely no reason for it:
https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/frame.js#L551
Unless there is a reason it should be eliminated
|
Reporter | |
Updated•14 years ago
|
Whiteboard: [mozmill-2.0?]
|
|
Reporter | |
Comment 1•14 years ago
|
||
Attachment #513202 -
Flags: review?(ahalberstadt)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 513202 [details] [diff] [review]
unify redundant methods that are redundant
r+
Attachment #513202 -
Flags: review?(ahalberstadt) → review+
|
|
Reporter | |
Updated•14 years ago
|
Whiteboard: [mozmill-2.0?] → [mozmill-2.0+]
|
|
Reporter | |
Comment 3•14 years ago
|
||
pushed to master: https://github.com/mozautomation/mozmill/commit/31cea99ec0a0b6998ab2d55403f85e6ea697c312
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
Assignee | |
Updated•9 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•